phpBB Forum

It is currently Wed 23. May 2012, 08:21

All times are UTC + 1 hour

Forum rules


Hello dearest user and welcome to our EQDKP-Plus support forum.

Please read the following rules and terms before posting anything! Failure in doing so will result in being ignored or being banned. Posting in our boards means you have read, understood and accepted those rules.

English Board Rules – Click here



Post new topic Reply to topic  [ 3 posts ] 
Author Message
Offline
 Post subject: Hide whisperoutput FIX
PostPosted: Thu 13. Jan 2011, 15:37 

Joined: Mon 25. Aug 2008, 16:58
Posts: 26
Currently the Hide whisperoutput option doesnt work. I know that, GetDKP will be updated, but this option is quite important and I think this fix will be useful.

As I play on 3.3.5a Server (not official one), I dont know if the bug exists on 4.0.x, too. But I had looked into WoW API and found this info about ChatFrame_AddMessageEventFilter function.

Quote:
3.1 change: The filter function is no longer passed "(msg)".
It is now passed the chat frame, the event and arg1, arg2 ... arg11.
If you return a non-nil arg1, you must also return all of arg2 ... arg11


... so I think this bug still exists even on 4.0.x

Source: http://www.wowwiki.com/API_ChatFrame_Ad ... ventFilter

So here is the fix:

OPEN [WoW_Dir] \ Interface \ AddOns \ GetDKP \ GetDKPCore \ GetDKP.lua

FIND (line: 1580,1581)
Code:
function GetDKP_BlockIncomingChatFrame_OnEvent(msg, arg1)
   --GDKP_Output("called Inc msg: "..arg1,"lokal");

REPLACE with
Code:
function GetDKP_BlockIncomingChatFrame_OnEvent(self, event, msg, author, ...)
   --GDKP_Output("called Inc msg: "..msg,"lokal");

FIND (line: 1583)
Code:
if is_dkpwhisper(msg, "Incoming", arg1) then

REPLACE with
Code:
if is_dkpwhisper(event, "Incoming", msg) then

FIND (line: 1590,1591)
Code:
function GetDKP_BlockOutgoingChatFrame_OnEvent(msg, arg1)
   --GDKP_Output("called Out msg: "..arg1,"lokal");

REPLACE with
Code:
function GetDKP_BlockOutgoingChatFrame_OnEvent(self, event, msg, author, ...)
   --GDKP_Output("called Out msg: "..msg,"lokal");

FIND (line: 1593)
Code:
if is_dkpwhisper(msg, "Outgoing", arg1) then

REPLACE with
Code:
if is_dkpwhisper(event, "Outgoing", msg) then

FIND (line: 1602,1603)
Code:
function is_dkpwhisper(msg, direction, arg1)
   local locmsg = strlower(arg1);

REPLACE with
Code:
function is_dkpwhisper(event, direction, msg)
   local locmsg = strlower(msg);

FIND (line: 1613)
Code:
startPos, endPos, firstWord, restOfString = string.find(locmsg, strlower(WHISPER_PREFIX));

REPLACE with
Code:
startPos, endPos, firstWord, restOfString = strfind(locmsg, strlower(WHISPER_PREFIX));


Im not really sure about that event argument, but as it is not used in whole function, I think it doesnt matter.

I wanted to attach this fixed file, but extension .lua is not allowed :/
I hope you willl successfuly fix this problem.

EDIT: ok uploaded as .zip file, just unzip it into [WoW_Dir] \ Interface \ AddOns


Attachments:
GetDKP.zip [16.83 KiB]
Downloaded 35 times



Last edited by TheBigTroll on Thu 13. Jan 2011, 15:53, edited 1 time in total.
Top
 Profile  
 
Offline
 Post subject: Re: Hide whisperoutput FIX
PostPosted: Thu 13. Jan 2011, 15:42 
Core-Developer
User avatar

Joined: Wed 10. Dec 2008, 13:06
Posts: 9025
Location: Heilbronn, Germany
zip it ;) zips are allowed


Support my work:
Image Image
Donate your played PS3 games:
Alternative: Donate your played Playstation3 games (PAL, Region Code 2).



Top
 Profile  
 
Offline
 Post subject: Re: Hide whisperoutput FIX
PostPosted: Thu 13. Jan 2011, 15:55 

Joined: Mon 25. Aug 2008, 16:58
Posts: 26
ok, attached into original post



Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 3 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  

(C) The EQdkp-Plus Developer Team
EQdkp Plus Template by Ramon Kaes